Parrot_readbc declares read_result as INTVAL, but assigns to it the
result of fread, which (on my system) is declared to return a size_t.
But later there is a check for a negative result, which makes no sense.
Are there systems on which fread returns a signed value, or should the
declaration of read_result be changed?  TIA,

                                        -- Bob "not a C hacker" Rogers
                                           http://rgrjr.dyndns.org/

------------------------------------------------------------------------
Diffs between last version checked in and current workfile(s):

Index: src/embed.c
===================================================================
--- src/embed.c (revision 26369)
+++ src/embed.c (working copy)
@@ -401,7 +401,7 @@
     if (io) {
         size_t chunk_size;
         char *cursor;
-        INTVAL read_result;
+        size_t read_result;
         INTVAL wanted;
 
         chunk_size = program_size > 0 ? program_size : 1024;

End of diffs.

Reply via email to