On Wednesday 19 March 2008 06:25:32 Klaas-Jan Stol wrote: > I don't commit this myself, because I want to check whether this > practice of localizing vars. is ok, as it introduces "else" clauses.
That seems reasonable. > Not sure whether which is better. My personal preference is the patch, > obviously. > Comments welcome, so I know how to do this in the future. My only comment is that it's much easier to apply patches if you create them from the root of the checkout (such that the patch is against src/io/io.c, not just io.c). Thanks, applied as r26631. -- c
