From: "James Keenan via RT" <[EMAIL PROTECTED]> Date: Sun, 13 Apr 2008 05:28:17 -0700
On Sat Apr 12 20:20:30 2008, rgrjr wrote: > There are only a few uses/references left in the > codebase: > > /usr/src/parrot/docs/pdds/draft/pdd06_pasm.pod > /usr/src/parrot/docs/pdds/draft/pdd19_pir.pod > /usr/src/parrot/editor/kate_syntax.pl > /usr/src/parrot/languages/BASIC/compiler/compile.pl > /usr/src/parrot/tools/util/ncidef2pasm.pl > Of these five files, the only ones that we (or, more to the point, I) could not safely do right away is languages/BASIC/compiler/compile.pl. This is the only instance where it appears to my untrained eyes that the ops are actually used . . . Yes, and this code is only used if debugging is enabled. This code appears to have been developed by Colin Kuskie, who was mostly active in Sept 2007. Two of the other files are drafts of PDDs. If we remove saveall and restoreall from the code, we don't have to document it anymore. Yup. Another file has to do with KATE syntax highlighting. I am not familiar with this (any KDE-users out there?). But it appears that the terms merely appear in a list of terms to get some particular highlighting. I think so (but I am not familiar with Kate, either). Probably this could afford to remain long after the ops are moved, in case someone who uses Kate finds some legacy code. The usages in ncidef2pasm.pl appear to have nothing per se to do with these ops . . . I couldn't even figure out what ncidef2pasm.pl was for, let alone how to test it. Is this dead code? So if we can deal with the BASIC instance, I think we can proceed. kid51 Note that the BASIC compiler debugging feature seems to be broken in other ways. This is why I didn't update BASIC on my first pass of eliminating saveall/restoreall usage; I couldn't test it. -- Bob