On Thursday 24 April 2008 12:08:57 Andy Dougherty wrote:

> Oops.  It won't work because I missed a level of indirection.
>
> > -    return STACK_DATAP(new_chunk);
>
> That used to return  &(new_chunk->u.data)
>
> > +    return new_chunk->u.stdata;
>
> And this returns new_chunk->u.stdata instead.
>
> Oops.  I can only say I was fooled by the function signatures that these
> functions returned 'void *', when they actually return 'void **'.

That one fooled me when I was working on it too.

> I'll try to fix that.  I apologize in advance if I wasted anyone's time
> trying this out.  (I still think my basic premise is right -- we can avoid
> pointer cast warnings and problems if we declare more explicitly what we
> wish to do.)

I agree.  I'm looking forward to a new patch.

-- c

Reply via email to