# New Ticket Created by  Will Coleda 
# Please include the string:  [perl #53352]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=53352 >


The following lines that use the STRUCT_COPY macro are generating
build warnings.

src/charset/ascii.c:792: warning: the address of 'base_set' will
always evaluate as 'true'
src/charset/binary.c:470: warning: the address of 'base_set' will
always evaluate as 'true'
src/charset/iso-8859-1.c:631: warning: the address of 'base_set' will
always evaluate as 'true'
src/charset/unicode.c:928: warning: the address of 'base_set' will
always evaluate as 'true'
src/encodings/fixed_8.c:558: warning: the address of 'base_encoding'
will always evaluate as 'true'
src/encodings/ucs2.c:578: warning: the address of 'base_encoding' will
always evaluate as 'true'
src/encodings/utf16.c:711: warning: the address of 'base_encoding'
will always evaluate as 'true'
src/encodings/utf8.c:898: warning: the address of 'base_encoding' will
always evaluate as 'true'

For example, the last line here is:

STRUCT_COPY(return_encoding, &base_encoding);

but base_encoding is declared just before that: static const ENCODING
base_encoding = {...}

The PARROT_ASSERT in the macro against base_encoding is then
apparently superfluous.

-- 
Will "Coke" Coleda

Reply via email to