On Thu, Jun 5, 2008 at 3:05 PM, Moritz Lenz <[EMAIL PROTECTED]> wrote:
> Ronald Schmidt wrote:
>> Moritz Lenz wrote:
>>> Oops, forgot to attach patch. Now it's really there.
>>>
>>>
>> Your implementations of eval_lives_ok and eval_dies_ok seem
>> inconsistent. eval_lives_ok uses try and eval_dies_ok does not. The
>> two implementations may catch different types of exceptions. I am
>> proposing the patch below:
>
> Good catch. Actually I already encountered I problem with these two
> subs, but haven't got around to fix it so far.
>
> Are there any exceptions that are not caught by eval?
> Currently rakudo seems to catch every run time exception, but parse
> failures still throw an exception. I'm pretty sure that's wrong, because
> it's contrary to Perl 6's exception philosophy.
>
> So eval() needs more work, but in the mean time your patch works just
> fine (and it will continue to work when eval is fixed), so I vote +1 here.
>
agreed, good catch. applied with some formatting tweaks (eg. putting
eval_exception() in the 'private' subs area) as r28124.
~jerry
