# New Ticket Created by  "jason switzer" 
# Please include the string:  [perl #56660]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=56660 >


I found a case where my Rakudo test harness and the spectest_regression.dat
were not in sync (needed to do an svn cleanup). The attached patch changes
the harness to raise a warning and skip the test when the test file cannot
be read by the user running the test. Duplicating the problem is slightly
more challenging. The 'svn up' in the Makefile must not update the pugs
smoke tests (it could be removed from the Makefile or require an svn cleanup
such as my case). Once this happened, I found it was trying to fudge a
missing script, which would only dump out the long fudgeall help message.
This patch gives a warning and skips the test, though it probably should be
a reported (measurable) error.

Thanks,

Jason "s1n" Switzer
Index: t/harness
===================================================================
--- t/harness	(revision 29114)
+++ t/harness	(working copy)
@@ -41,7 +41,11 @@
         my ($fn, $fudgespec) = split m/\s+#\s*/;
         $fn = "t/spec/$fn" unless $fn =~ m/^t\Q$slash\Espec\Q$slash\E/;
         $fn =~ s/\//$slash/g;
-        $accepted_tests{$fn} = $fudgespec;
+        if( -r $fn ) {
+            $accepted_tests{$fn} = $fudgespec;
+        } else {
+            warn "Missing test file: $fn\n";
+        }
     }
     close $f;
 }

Reply via email to