On Saturday 12 July 2008 21:52:52 Christoph Otto via RT wrote:

> The test now passes, although I'll leave this ticket open until someone
> can confirm that it still does the right thing.
>
> The new version of t/codingstd/c_macro_args.t as of r29372 has several
> special cases: stringification, concatenation, use of args as types when
> pointers to that type are cast/created, function argument
> instrumentation, args as function names and macros which recursively use
> macros which use concatenation.  This last case is used mostly in
> includes/parrot/pobj.h for testing, setting and clearing flags.  These
> macros could be rewritten, but there are enough of them that it's easier
> just to tell the test that these macros are ok.
>
> I would appreciate comments on whether this is the right approach.

+1 for modifying the test, not the macros.

-- c

Reply via email to