On Thu, Jul 17, 2008 at 7:44 PM, Christoph Otto via RT
<[EMAIL PROTECTED]> wrote:
> On Thu Jul 17 15:53:12 2008, julianalbo wrote:
>> On Thu, Jul 17, 2008 at 9:59 PM, Christoph Otto via RT
>> <[EMAIL PROTECTED]> wrote:
>>
>> > With this patch, the new tests still pass on Linux/x86. The patch uses
>> > STRING->strstart to avoid leaking a malloc'd buffer when throwing an
>> > exception, which may or may not be considered kosher in this situation.
>>
>> Can't you use real_exception(interp, NULL, E_SystemError, "%Ss",
>> errmsg_pstring); ?
>>
>> Using internal details of parrot strings must be avoided.
>>
>
> I agree. I just didn't know real_exception was smart enough to do that
> trick. The attached patch (v5) properly fixes the problem on my system.
> There shouldn't be any remaining issues, but the patch ought to be
> tested on a another *nix and Windows.
>
iirc we shouldn't be assuming interp in macros (it should always be passed).
i could be wrong, so i've copied the man with the feathered broom for
an official ruling.
~jerry
