On Fri, Jul 18, 2008 at 10:13 AM, Michael Peters <[EMAIL PROTECTED]> wrote: > James Keenan via RT wrote: >> >> I was told on #parrot that you have to replace # TODO comments by >> creating RT tickets and referencing the RT instead of the TODO. >> >> Perhaps it would be simpler to just delete these comments. Please >> advise. Thank you very much. > > The first one (line 103) refers to the _get_svn_revision() number and > expanding it to cover git and svk. But looking at recent discussions on this > list it seems that the best way is to just pull it from %PConfig. > > The 2nd one can just be turned into a comment about what is possible. > Patch attached. > > -- > Michael Peters > Plus Three, LP > > > Index: lib/Parrot/Harness/Smoke.pm > =================================================================== > --- lib/Parrot/Harness/Smoke.pm (revision 29580) > +++ lib/Parrot/Harness/Smoke.pm (working copy) > @@ -95,20 +95,12 @@ > 'Optimize' => ($PConfig{optimize} || 'none'), > 'Perl Version' => (sprintf('%vd', $^V) . " $PConfig{archname}"), > 'Platform' => $PConfig{osname}, > - 'SVN Revision' => _get_svn_revision(), > + 'SVN Revision' => $PConfig{revision}, > 'Version' => $PConfig{VERSION}, > ); > } > > -# TODO expand this to handle svk and/or git checkouts too > -sub _get_svn_revision { > - foreach my $line (`svn info`) { > - return $1 if $line =~ /^Revision:\s*(\d+)/; > - } > - return 'unknown'; > -} > - > -# TODO expand this to more than just GCC > +# this can be expanded to more than just GCC > sub _get_compiler_version { > my $compiler = $PConfig{cc}; > if($compiler eq 'gcc') { > >
Minor patch applied in r29592. -- Will "Coke" Coleda