On Sun Sep 02 14:31:10 2012, ronaldxs wrote:
> Once again I came across a small Makefile critter that blocks the build 
> of Rakudo Star 2012-08 on Cygwin.  It appears that Star uses the 2012.08 
> tag for NQP in Rakudo Star which is the following commit with, what 
> would appear to be, a small oversight: 
> https://github.com/perl6/nqp/commit/fff3eb81c0df3619e6ddecd56e7e245127603d58
> 
> The commit removes P5QREGEX_PBC from part of the build process but 
> leaves it around in tools/build/Makefile.in on line 539 for the install 
> target.  This breaks on cygwin because, for reasons related to a known 
> problem, cygwin does cp a bit differently and returns a failing return 
> code to make.  Anyway a "-" just before rule on that line to ignore the 
> return code fixes the problem and allowed me to finish building Rakudo 
> Star on cygwin through "make install".  Removing the line appears to 
> work too although I have not tested completely.
> 
> Ron
> 
> 
> So nqp/tools/build/Makefile.in:
> 
> install: all
>       $(MKPATH)                   $(DESTDIR)$(PARROT_LIBRARY_DIR)
>       $(CP)  $(MODULE_LOADER_PBC) 
> $(DESTDIR)$(PARROT_LIBRARY_DIR)/$(MODULE_LOADER_PBC)
>       $(CP)  $(PAST_PBC)          
> $(DESTDIR)$(PARROT_LIBRARY_DIR)/$(PAST_PBC)
>       $(MKPATH)                   $(DESTDIR)$(NQP_LANG_DIR)/lib
>       $(CP)  $(QAST_PBC)          $(DESTDIR)$(NQP_LANG_DIR)/lib/$(QAST_PBC)
>       $(CP)  $(P6QREGEX_PBC)      
> $(DESTDIR)$(NQP_LANG_DIR)/lib/$(P6QREGEX_PBC)
>       $(CP)  $(P5QREGEX_PBC)      
> $(DESTDIR)$(NQP_LANG_DIR)/lib/$(P5QREGEX_PBC)
>       $(CP)  $(HLL_PBC)           $(DESTDIR)$(NQP_LANG_DIR)/lib/$(HLL_PBC)
> 
> Is fixed with a change to:
> 
> install: all
>       $(MKPATH)                   $(DESTDIR)$(PARROT_LIBRARY_DIR)
>       $(CP)  $(MODULE_LOADER_PBC) 
> $(DESTDIR)$(PARROT_LIBRARY_DIR)/$(MODULE_LOADER_PBC)
>       $(CP)  $(PAST_PBC)          
> $(DESTDIR)$(PARROT_LIBRARY_DIR)/$(PAST_PBC)
>       $(MKPATH)                   $(DESTDIR)$(NQP_LANG_DIR)/lib
>       $(CP)  $(QAST_PBC)          $(DESTDIR)$(NQP_LANG_DIR)/lib/$(QAST_PBC)
>       $(CP)  $(P6QREGEX_PBC)      
> $(DESTDIR)$(NQP_LANG_DIR)/lib/$(P6QREGEX_PBC)
>       - $(CP)  $(P5QREGEX_PBC)      
> $(DESTDIR)$(NQP_LANG_DIR)/lib/$(P5QREGEX_PBC)
>       $(CP)  $(HLL_PBC)           $(DESTDIR)$(NQP_LANG_DIR)/lib/$(HLL_PBC)

It looks like P5QREGEX_PBC is now part of the default build:

all: $(NQP_EXE) $(P5QREGEX_PBC)

so the workaround on the copy should no longer necessary. Closing this ticket - 
if you find any 
more cygwin related issues, please let us know. Thanks.



-- 
Will "Coke" Coleda

Reply via email to