parrot hackers,
I'm not going to pretend to be a wizened hacker, but I've got a couple
of questions about Parrot::Opcode that I hope you could answer.

1)  _load looks like:

sub _load {
    #
    # 
    #
    my $count = 1;
    while (<$fh>) {
       #
       #
       #
        if (@params && $params[0] =~ /^\d+$/) {
            my $count = shift @params;
            die "$file, line $.: opcode $name parameters don't match count\n"
              if ($count != @params);
        }
       #
       #
       #
}  

I realize that the $count inside the if block shown masks the $count
declared outside the while loop, but (to me) this would be easier to
understand if the inner $count where changed to $numParams -- it is more
obvious on casual reading that $count and $count are two different
things.  Am I missing something?

2) It also appears that a second (older?) version of read_ops and an
associated pile of pod is still in the Opcode.pm file can this be
trimmed (removing about 80 lines from the file)?



thanks,
-pate

Reply via email to