# New Ticket Created by  Bruce Gray 
# Please include the string:  [perl #17506]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt2/Ticket/Display.html?id=17506 >


lib/Parrot/Configure/Step.pm, in sub cc_clean, is trying to 
clean up its test compiles by 'unlink glob <test.*>'.
This fails to remove 'test', the executable name under 
Unixes, because it has no extension. Also, the unlink is
unnecessarily aggressive; it might remove 
'test.o.i_saved_for_a_reason. Step.pm created all the test 
files, and it should know how to enumerate them during 
cleanup. This patch teaches it how.

Hope this helps,
Bruce Gray


-- attachment  1 ------------------------------------------------------
url: http://rt.perl.org/rt2/attach/38279/31132/7e215b/step_test_glob_cleanup.patch

Index: parrot/lib/Parrot/Configure/Step.pm
===================================================================
RCS file: /cvs/public/parrot/lib/Parrot/Configure/Step.pm,v
retrieving revision 1.9
diff -u -r1.9 Step.pm
--- parrot/lib/Parrot/Configure/Step.pm 4 Sep 2002 23:17:56 -0000       1.9
+++ parrot/lib/Parrot/Configure/Step.pm 22 Sep 2002 21:18:57 -0000
@@ -149,7 +149,9 @@
 }
 
 sub cc_clean {
-       unlink glob "test.*";
+       unlink map "test$_",
+               qw( .c .cco .ldo ),
+               Configure::Data->get( qw( o exe ) );
 }
 
 1;

Reply via email to