Nicholas Clark <[EMAIL PROTECTED]> wrote:
> I've just fallen into this trap, and I doubt I'll be the last one:
> void Parrot_PMC_set_intval_intkey(Parrot_INTERP interp, Parrot_PMC pmc, Parrot_Int
> value, Parrot_Int key) {
> VTABLE_set_integer_keyed_int(interp, pmc, key, value);
>}
> Is there any reason why the vtable is key, value but the extension
> interface is value, key? This parameter transposition strikes me as
> asking for trouble.
It seems order was chosen according to function name (_intval _intkey).
> I'll patch everything in core to make value last if consensus is that
> this is the right thing to do.
Yep. I'd swap function names as well as argument order, so that
everything matches the vtable prototype.
> Nicholas Clark
leo
