On Fri, Nov 19, 2004 at 04:30:06PM -0500, Andy Dougherty wrote: > > Ok, here's a first pass. Most of it is pretty straightforward, but one > thing is worth noting: > > The code uses both signed and unsigned chars, with and without the 'const' > qualifier. I gather this is a deliberate part of a carefully considered > overall design.
You're being very kind, but no, it's an indication of my working too late one night. It really should all be unsigned characters, and its fixed now, as well as the bunches of warnings that gcc was giving when compiling everything. > Without understanding the underlying design, I don't know offhand what to > recommend, but this patch works for me and highlights spots where some > further thought might be needed. Thanks a *bunch* for this -- I've gone ahead and applied the patches (along with other cleanups) and committed them into CVS. A test suite harness for p6ge should be coming within the next day or so-- stay tuned. Pm
