On Fri Mar 30 23:36:45 2007, [EMAIL PROTECTED] wrote: > Hi, > > I'm bored, so I'm going through and fixing some failing tests in > t/codingstd/ > > At the moment I'm working on c_parens.t. Here's one that fixes the > majority of the failures in the first third of the tests, which looks > that code matches the pattern > > C-keyword exactly-one-space open-parenthesis > > I only fixed the ones that were mostly obvious. How is sizeof supposed > to be treated? It's a keyword, yes, but most C code I've seen has no > space between the sizeof and (. So I didn't touch those failures. I > also didn't change things where spacing created a layout, such as in > > typedef void (*push_number_f) (Parrot_Interp, IMAGE_IO*, > FLOATVAL); > typedef INTVAL (*shift_integer_f) (Parrot_Interp, IMAGE_IO*); > > I can try to write something to make the above case pass (look for a > parenthesis in the same column a line above or below), but that'll > come later. > > make test obviously returned no new failures; prove > t/codingstd/c_paren.t had a reduction of 40 files to 33. A lot of > these failures are sizeof or layout related, honest! > > Affected files (yay diffstat): > compilers/imcc/imc.h | 2 - > compilers/imcc/imcc.y | 16 +++++++------- > compilers/pirc/src/pirlexer.c | 34 > ++++++++++++++--------------- > compilers/pirc/src/pirparser.c | 30 +++++++++++++------------- > include/parrot/encoding.h | 2 - > include/parrot/packfile.h | 4 +-- > include/parrot/smallobject.h | 2 - > languages/cola/cola.y | 42 > ++++++++++++++++++------------------- > languages/lua/pmc/luastring.pmc | 2 - > languages/pugs/pmc/pugscapture.pmc | 2 - > languages/tcl/src/pmc/tcllist.pmc | 2 - > src/inter_call.c | 6 ++--- > 12 files changed, 72 insertions(+), 72 deletions(-) > > Shawn M Moore
Thanks! It's great to have someone help out :-) Eventually all applied in r17893. Paul
