while reviewing a patch this morning
(http://perlsix.org/svn/parrot/revision/?rev=20876,) the commit
message didn't match the code precisely.
comment:
[imcc] Checking that the index passed to the C<regs> array in
C<branch_cond_loop_swap> isn't negative, which it potentially can be. This
resolves Coverity CID 21.
code:
reg_index = get_branch_regno(cond);
if (reg_index == -1) {
so, i wanted to see if C<get_branch_regno()> could return any other
negative values. i used C<Ctrl-]>, which is a way to navigate tags in
vim. vim reported no tag found. to be sure, i tried C<gvim -t
get_branch_regno>, which opens the file and line corresponding to that
tag, and also failed.
C<ack> tells me the function is defined at
F<compilers/imcc/instructions.c>, line 306.
as it turns out, the function can return any integer, so the code must
be updated. but why isn't that function in the tags file?
~jerry
