On Jan 12, 2008, at 9:42 AM, James Keenan (via RT) wrote:
# New Ticket Created by James Keenan # Please include the string: [perl #49668] # in the subject line of all future correspondence about this issue. # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=49668 > Test file t/op/jit.t currently (r24787) has 1274 lines. Examine this file and determine whether the file can reasonably be divided into smaller test files (such as files of less than 1000 lines). If so, subdivide the file. If not, take and resolve this ticket. Happy hacking! kid51
With t/op/jit.t they're primarily special case tests. For the tests to work accurately(that is to test what they're intended to test) require the platform jit's to use certain register assignments which could be slower for platforms with more registers available so is mainly a jit developer test file. At line 1223 starts a test named "div bug" because of how x86 handle the integer division opcode, which uses two registers implicitly and one explicitly, and those first two could be used for other data and not preserved. I wouldn't necessarily split up t/op/jit.t just because it is testing special cases, but maybe expanding the description in the file. Otherwise later on some of the tests could be potentially removed without knowing why it was needed.
