On Thu Jan 24 17:43:06 2008, doughera wrote:
>
> This sounds like a problem in the hints file. I don't know what platform
> this is, but I'd look in the hints file to see if it unconditionally
> sets ccflags and ldflags without checking the command line options.
>
It's Darwin, whose hints file does indeed make no check of command-line
options. By analogy with the hints files for Linux and Win32, I propose
the patch attached: hints.darwin.patch.txt
>
> Note that this test doesn't try setting ccflags or ldflags, so it is
> irrelevant to the problem at hand.
>
True enough. So since I don't try setting the flags, the most I can
prove is that checking them with option_or_data() in init::hints::darwin
does no harm. Coke will have to try it and see if it actually benefits him.
Index: config/init/hints/darwin.pm
===================================================================
--- config/init/hints/darwin.pm (revision 25207)
+++ config/init/hints/darwin.pm (working copy)
@@ -9,7 +9,10 @@
sub runstep {
my ( $self, $conf ) = @_;
- my ( $ccflags, $ldflags, $libs ) = $conf->data->get(qw(ccflags ldflags
libs));
+# my ( $ccflags, $ldflags, $libs ) = $conf->data->get(qw(ccflags ldflags
libs));
+ my $ccflags = $conf->option_or_data( 'ccflags' );
+ my $ldflags = $conf->option_or_data( 'ldflags' );
+ my $libs = $conf->option_or_data( 'libs' );
my $OSVers = `uname -r`;
chomp $OSVers;
