On Sunday 23 March 2008 19:17:41 James Keenan via RT wrote:
> Index: lib/Parrot/Configure/Utils.pm
> ===================================================================
> --- lib/Parrot/Configure/Utils.pm (revision 26524)
> +++ lib/Parrot/Configure/Utils.pm (working copy)
> @@ -311,6 +312,17 @@
>
> =back
>
> +=cut
> +
> +sub append_configure_log {
> + my $target = shift;
> + my $generated_log = q{MANIFEST.configure.generated};
> + open my $GEN, '>>', $generated_log
> + or die "Can't open $generated_log for appending: $!";
> + print $GEN qq{$target\n};
> + close $GEN or die "Can't close $generated_log after appending: $!";
> +}
> +
I don't understand this mixture of '', q{}, "", and qq{} across four lines. I
recommend sticking with one quoting convention (and in the absence of the
need to escape the quoting character currently in use, my preference is ''
and "").
-- c
