# New Ticket Created by James Keenan
# Please include the string: [perl #58296]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=58296 >
I've spent several hours this morning trying to fix failing coding
standards tests. Most of these failures occur in files in compilers/
ncigen/; I believe they may have resulted from the merge done in r30452.
I've cleaned up a lot of these, but many still remain. See attached.
t/codingstd/c_indent...........1/2
# Failed test 'Correctly indented preprocessor directives'
# at t/codingstd/c_indent.t line 213.
# incorrect indenting in preprocessor directive found 47 occurrences in 1 files:
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:16
# got: #define SPI_Hexpected: # define SPI_H -- it's inside of #ifndef
SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:22
# got: #include "postgres.h"expected: # include "postgres.h" -- it's
inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:28
# got: #include "access/heapam.h"expected: # include "access/heapam.h" --
it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:29
# got: #include "access/xact.h"expected: # include "access/xact.h" --
it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:30
# got: #include "catalog/pg_language.h"expected: # include
"catalog/pg_language.h" -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:31
# got: #include "catalog/pg_proc.h"expected: # include
"catalog/pg_proc.h" -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:32
# got: #include "catalog/pg_type.h"expected: # include
"catalog/pg_type.h" -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:33
# got: #include "executor/execdefs.h"expected: # include
"executor/execdefs.h" -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:34
# got: #include "executor/executor.h"expected: # include
"executor/executor.h" -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:35
# got: #include "nodes/execnodes.h"expected: # include
"nodes/execnodes.h" -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:36
# got: #include "nodes/params.h"expected: # include "nodes/params.h" --
it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:37
# got: #include "nodes/parsenodes.h"expected: # include
"nodes/parsenodes.h" -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:38
# got: #include "nodes/plannodes.h"expected: # include
"nodes/plannodes.h" -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:39
# got: #include "nodes/primnodes.h"expected: # include
"nodes/primnodes.h" -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:40
# got: #include "nodes/relation.h"expected: # include "nodes/relation.h"
-- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:41
# got: #include "tcop/dest.h"expected: # include "tcop/dest.h" -- it's
inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:42
# got: #include "tcop/pquery.h"expected: # include "tcop/pquery.h" --
it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:43
# got: #include "tcop/tcopprot.h"expected: # include "tcop/tcopprot.h" --
it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:44
# got: #include "tcop/utility.h"expected: # include "tcop/utility.h" --
it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:45
# got: #include "utils/builtins.h"expected: # include "utils/builtins.h"
-- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:46
# got: #include "utils/datum.h"expected: # include "utils/datum.h" --
it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:47
# got: #include "utils/portal.h"expected: # include "utils/portal.h" --
it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:48
# got: #include "utils/syscache.h"expected: # include "utils/syscache.h"
-- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:63
# got: #define SPI_ERROR_CONNECT (-1)expected: # define
SPI_ERROR_CONNECT (-1) -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:64
# got: #define SPI_ERROR_COPY (-2)expected: # define
SPI_ERROR_COPY (-2) -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:65
# got: #define SPI_ERROR_OPUNKNOWN (-3)expected: # define
SPI_ERROR_OPUNKNOWN (-3) -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:66
# got: #define SPI_ERROR_UNCONNECTED (-4)expected: # define
SPI_ERROR_UNCONNECTED (-4) -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:67
# got: #define SPI_ERROR_CURSOR (-5) /* not used anymore
*/expected: # define SPI_ERROR_CURSOR (-5) /* not used anymore */ --
it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:68
# got: #define SPI_ERROR_ARGUMENT (-6)expected: # define
SPI_ERROR_ARGUMENT (-6) -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:69
# got: #define SPI_ERROR_PARAM (-7)expected: # define
SPI_ERROR_PARAM (-7) -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:70
# got: #define SPI_ERROR_TRANSACTION (-8)expected: # define
SPI_ERROR_TRANSACTION (-8) -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:71
# got: #define SPI_ERROR_NOATTRIBUTE (-9)expected: # define
SPI_ERROR_NOATTRIBUTE (-9) -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:72
# got: #define SPI_ERROR_NOOUTFUNC (-10)expected: # define
SPI_ERROR_NOOUTFUNC (-10) -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:73
# got: #define SPI_ERROR_TYPUNKNOWN (-11)expected: # define
SPI_ERROR_TYPUNKNOWN (-11) -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:75
# got: #define SPI_OK_CONNECT 1expected: # define
SPI_OK_CONNECT 1 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:76
# got: #define SPI_OK_FINISH 2expected: # define SPI_OK_FINISH
2 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:77
# got: #define SPI_OK_FETCH 3expected: # define SPI_OK_FETCH
3 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:78
# got: #define SPI_OK_UTILITY 4expected: # define
SPI_OK_UTILITY 4 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:79
# got: #define SPI_OK_SELECT 5expected: # define SPI_OK_SELECT
5 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:80
# got: #define SPI_OK_SELINTO 6expected: # define
SPI_OK_SELINTO 6 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:81
# got: #define SPI_OK_INSERT 7expected: # define SPI_OK_INSERT
7 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:82
# got: #define SPI_OK_DELETE 8expected: # define SPI_OK_DELETE
8 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:83
# got: #define SPI_OK_UPDATE 9expected: # define SPI_OK_UPDATE
9 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:84
# got: #define SPI_OK_CURSOR 10expected: # define
SPI_OK_CURSOR 10 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:85
# got: #define SPI_OK_INSERT_RETURNING 11expected: # define
SPI_OK_INSERT_RETURNING 11 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:86
# got: #define SPI_OK_DELETE_RETURNING 12expected: # define
SPI_OK_DELETE_RETURNING 12 -- it's inside of #ifndef SPI_H
# /home/jimk/work/formergeops/compilers/ncigen/t/spi.c:87
# got: #define SPI_OK_UPDATE_RETURNING 13expected: # define
SPI_OK_UPDATE_RETURNING 13 -- it's inside of #ifndef SPI_H
# Looks like you failed 1 test of 2.
t/codingstd/c_indent........... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests
t/codingstd/c_macro_args.......ok
t/codingstd/c_operator.........ok
t/codingstd/c_parens...........ok
t/codingstd/c_returns..........ok
t/codingstd/c_struct...........ok
t/codingstd/check_isxxx........ok
t/codingstd/check_toxxx........ok
t/codingstd/copyright..........ok
t/codingstd/cuddled_else.......ok
t/codingstd/filenames..........ok
t/codingstd/gmt_utc............ok
t/codingstd/linelength.........ok
t/codingstd/pccmethod_deps.....ok
t/codingstd/perlcritic.........2/335
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/formergeops/compilers/ncigen/lib/Parrot/Test/C99AST.pm"'
# at t/codingstd/perlcritic.t line 69.
#
# Perl::Critic found these violations in
"/home/jimk/work/formergeops/compilers/ncigen/lib/Parrot/Test/C99AST.pm":
# Subroutine prototypes used at
/home/jimk/work/formergeops/compilers/ncigen/lib/Parrot/Test/C99AST.pm line 146
t/codingstd/perlcritic.........5/335
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/formergeops/compilers/ncigen/nci_gen.pl"'
# at t/codingstd/perlcritic.t line 69.
#
# Perl::Critic found these violations in
"/home/jimk/work/formergeops/compilers/ncigen/nci_gen.pl":
# Found platform-specific perl shebang line at
/home/jimk/work/formergeops/compilers/ncigen/nci_gen.pl line 1
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/formergeops/compilers/ncigen/src/parser/actions.pm"'
# at t/codingstd/perlcritic.t line 69.
#
# Perl::Critic found these violations in
"/home/jimk/work/formergeops/compilers/ncigen/src/parser/actions.pm":
# Missing properly located perl coda for parrot source at
/home/jimk/work/formergeops/compilers/ncigen/src/parser/actions.pm line 4
t/codingstd/perlcritic.........335/335 # Looks like you failed 3 tests of 335.
In particular, I'm unsure how to fix the 47 failures reported in
compilers/ncigen/t/spi.c by t/codingstd/c_indent.t.
Thank you very much.
