On Sat Sep 13 09:17:22 2008, [EMAIL PROTECTED] wrote:
>
> > Also, your patch causes two tests in t/steps/auto_icu-01.t to fail.
>
> You are right. I forget to change the tests according.
> If the change to "config/auto/icu.pm" should be applied the tests
> should
> also be changed.
>
> for example:
> $icushared = qq{-licui18n -lalpha\n};
> to
> $icushared = qq{-lalpha\n};
>
Can you add a revision for auto_icu-01.t to your patch?
I ask because auto::icu was added to the configuration system only
relatively recently, and we had to go through considerable effort to get
it to be located/tested correctly on all OSes. So people who are
reviewing your patch on, e.g., win32, will need a revision to the test
file as well.
Thank you very much.
kid51
