Thanks for the review. I'll make the text changes. I think we'll want to keep the pdl> prompt text in the interactive examples so it is clear what is user input and what is output. It should be consistent though. Also, for consistency:
- verbatim example paragraphs should be indented the same throughout the book (say 2 spaces) - put the ; at the end of example code lines (they may not be required interactively, but it will keep folks from being surprised if they cut and paste to start a program file... Thanks, Chris On 1/22/2012 12:44 PM, Mike Burns wrote:
Just went through PDL::Book::FirstSteps and found some stuff that are candidates to be fixed: * In "Alright let's do something" section, second paragraph 'editting' should be 'editing' * In the stand-alone script example for spiral graph there should be a 'use PDL::Graphics::PGPLOT;' after 'use PDL;' * In "Measuring the brightness of M51" - first two pdl shell examples start 'pdl>', maybe take those out for consistency? * In "Twinkle, twinkle, little star": ** description of '$section = $gal(337:357,178:198);' says range is 327 to 367 and 168 and 208. Is that correct? Maybe I'm not understanding NiceSlice very well ... ** in example to get the FWHM is has 'print $peak, $fwhm, $background;' - it should probably be 'p $peak ...' since print doesn't put spaces between the numbers ** In the fake star script I had to add 'use PDL::NiceSlice;' otherwise I got an error that would likely confuse new PDL users * The description of the figures don't start numbering them until 1.6. Maybe number them all? * May also want to mention about the aspect ratio before displaying images. For me, using a fresh install, the images were stretched wider than the examples shown. Might cause confusion for some beginners. Other than those, everything worked as expected. I tried everything in pdl2 and had no issues. I'll continue proofreading. Mike _______________________________________________ Perldl mailing list [email protected] http://mailman.jach.hawaii.edu/mailman/listinfo/perldl ----- No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1416 / Virus Database: 2109/4759 - Release Date: 01/22/12
_______________________________________________ Perldl mailing list [email protected] http://mailman.jach.hawaii.edu/mailman/listinfo/perldl
