I am all for setting up a smoke system, I have advocated creating a PDL-centric on in the past but haven't had the tuits to write one. However, Lee's edits are purely documentation edits and are going to go through a code review, so I thought it was safe for now. Another way to play it safe would be a model in which new contributors would work off of a core developer's fork of PDL so that the core developer could pull the changes into their setup and try them before pushing them to the main repo. This, however, would require even more coordination between core developers and new contributors than proposing direct edits.
At any rate, we don't need to suss this out until we start to get a ton of contributions from a ton of new people, a deluge that PDL does not suffer at the moment. :-) David On Fri, Jan 25, 2013 at 7:33 AM, Joel Berger <[email protected]>wrote: > If we are going to start proposing online edits (not fork/clone/pull-req) > we should setup a travis smoker, which will automatically run smoke tests > (but only on ubuntu). This prevents merging a non-tested non-runnable pull > which is easier to happen from an online-only edit. > > Joel > > On Fri, Jan 25, 2013 at 6:42 AM, David Mertens > <[email protected]>wrote: > >> Lee - >> >> On Fri, Jan 25, 2013 at 1:44 AM, Lee <[email protected]> wrote: >> >>> Thanks. I just tried logging in to SourceForge to put this (and which) >>> on the Perl for Matlab page, but although I am logged in to SF, there is no >>> edit link on the project page. Is this something for which I need to apply? >>> >>> <snip> >>> >> >> SourceForge is where we keep the master repository for PDL, but it's >> actually easier for new contributors to work through the mirrored >> repository on Github. The basic process is to edit the file online and >> submit a pull request. For your edits, I suggest that you >> >> 1. create an account on Github if you don't already have one, >> 2. go to the page of the source file, in this case, here: >> https://github.com/PDLPorters/pdl/blob/master/Basic/Pod/MATLAB.pod, >> 3. click the "Edit" button in the upper right of the page and make >> your edits (it's written in Perl's documentation format, called POD, in >> case it looks unusual), >> 4. describe in a couple of sentences what you changed in the >> "Extended description" box at the bottom of the page and click "Propose >> File Change", >> 5. on the New Pull Request page, click "Send Pull Request" (it'll >> copy your extended description as the description for the pull request, >> which should be fine here), >> 6. and finally, one of the PDL/Github folks will look at the pull >> request and either pull it immediately or give feedback on how to improve >> it before it gets pulled in. >> >> There are a couple of different directions to go from there, but we need >> not cover those details now. Give that a whirl and let us know how it goes, >> and thanks for offering to clean up the Matlab docs! >> >> David >> -- >> "Debugging is twice as hard as writing the code in the first place. >> Therefore, if you write the code as cleverly as possible, you are, >> by definition, not smart enough to debug it." -- Brian Kernighan >> >> _______________________________________________ >> Perldl mailing list >> [email protected] >> http://mailman.jach.hawaii.edu/mailman/listinfo/perldl >> >> > -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." -- Brian Kernighan
_______________________________________________ Perldl mailing list [email protected] http://mailman.jach.hawaii.edu/mailman/listinfo/perldl
