> >> SOR with multis dof? > > ex43 and snes ex19 do that in multigrid and there are other examples > that test more sizes of SOR. >
In that case I can not think of anything that these test are testing other than gamg. So it sounds like you are saying that tests -- tutorial tests -- should not have any parameters that are not tested someplace else. They should be completely orthogonal. These tests are not at all. Never were. I will withdraw these pull requests because they are trying to do the wrong thing. THe problem is not that they are using parameters that are not recommended but that they are not strictly orthogonal to all other tests. >>> >> >> As I have said so many times but let me add. I use tests as a starting >> point, for code and for parameters on how to run the code. In the >> future it is natural if someone adds a GAMG test that they will start >> with an existing example. Cheby/Jacobi was causing very frustrating >> failures and I want to kill it. This things get cut and pasted, as >> they should, and Cheby/Jacobi is a virus that I want to kill. > > Hmm, and yet I'm pretty sure I recall you arguing for it earlier because > it parallelizes trivially and performs decently. I'm not sure what "it" is but everything on the table paralyzed trivially and performs decently. It is the occasional failure of Cheby/Jacobi that motivated this change. > I don't have a problem > with changing it (provided Cheby/Jacobi smoothers are still tested > somewhere), but I would like a commit message that says why so that one > of us doesn't come along next year and change it some other way. > I will add a Cheby/Jacobi smoother test. I see many many GMRES/Jocobi tests.
