On Tue, Oct 24, 2017 at 4:22 PM, Adrian Croucher <a.crouc...@auckland.ac.nz> wrote:
> hi, > > On 11/10/17 22:18, Matthew Knepley wrote: > > On Tue, Oct 10, 2017 at 9:07 PM, Adrian Croucher < > a.crouc...@auckland.ac.nz> wrote: > >> hi >> >> On 03/08/17 13:10, Matthew Knepley wrote: >> >> On Wed, Aug 2, 2017 at 8:06 PM, Adrian Croucher < >> a.crouc...@auckland.ac.nz> wrote: >> >>> I haven't tried this myself, but two of my colleagues are reporting >>> problems accessing DMLabel from Fortran, when using the latest 'next' >>> branch. >>> >>> Previously, #include <petsc/finclude/petsc.h> and then 'use petsc' would >>> give access to DMLabel. >>> >>> But now it appears that doesn't work- you need to include petscdmlabel.h >>> as well. >>> >>> Is that a bug or a feature? >> >> >> Its a bug. We refactored DMLabel to make all functionality available from >> Fortran, including using it as a type, but >> I did not put the new header inside petsc.h. I can do that. >> >> Matt >> >> >> >> It appears this never got done, so I have had a look and (I think) >> figured out how to fix it myself. >> >> I've just submitted a pull request with the fix in a branch called >> acroucher/fix-fortran-dmlabel. >> > > Sorry about that. We will get this in this week. > > > Was there a problem with that? It doesn't appear to have been merged in > yet. > This is me being stupid. I needed to rebase it onto maint and I forgot about it. I merged it to next just now. If everything is fine tomorrow, I will merge to maint and master. Thanks, Matt > > - Adrian > > -- > Dr Adrian Croucher > Senior Research Fellow > Department of Engineering Science > University of Auckland, New Zealand > email: a.crouc...@auckland.ac.nz > tel: +64 (0)9 923 4611 <+64%209-923%204611> > > -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener https://www.cse.buffalo.edu/~knepley/ <http://www.caam.rice.edu/~mk51/>