Moreover, after a second look, I think MatSetOperation() is wrong. It should special-case MATSHELL and dispatch to MatShellSetOperation() if the type match, otherwise bad things would happen.
On 1 April 2018 at 12:08, Lisandro Dalcin <dalc...@gmail.com> wrote: > Barry, you made the distinction MatSetOperation() vs. MatShellSetOperation(). > > 1) MatSetOperation() is misplaced, it should go somewhere in > src/mat/interface/matrix.c > > 2) We should add MatGetOperation(), right? Should it just return the > routine set in mat-ops? Are you ok with this? > > > > -- > Lisandro Dalcin > ============ > Research Scientist > Computer, Electrical and Mathematical Sciences & Engineering (CEMSE) > Extreme Computing Research Center (ECRC) > King Abdullah University of Science and Technology (KAUST) > http://ecrc.kaust.edu.sa/ > > 4700 King Abdullah University of Science and Technology > al-Khawarizmi Bldg (Bldg 1), Office # 0109 > Thuwal 23955-6900, Kingdom of Saudi Arabia > http://www.kaust.edu.sa > > Office Phone: +966 12 808-0459 -- Lisandro Dalcin ============ Research Scientist Computer, Electrical and Mathematical Sciences & Engineering (CEMSE) Extreme Computing Research Center (ECRC) King Abdullah University of Science and Technology (KAUST) http://ecrc.kaust.edu.sa/ 4700 King Abdullah University of Science and Technology al-Khawarizmi Bldg (Bldg 1), Office # 0109 Thuwal 23955-6900, Kingdom of Saudi Arabia http://www.kaust.edu.sa Office Phone: +966 12 808-0459