On Thu, 28 Jun 2018 at 19:16, Lawrence Mitchell <we...@gmx.li> wrote: > > This uses the Push/Pop stuff that I added in PR#604, in response to noting > (in PCPATCH runs) that 90% of the time was spent in XXXViewFromOptions. > After adding the push/pop pair, this dropped to basically 0%. I didn't do > further exhaustive benchmarking to check for further problems. >
There you have! Thanks for confirming my previous guess. I would really like that PR being split, and leave the changes to XXXSetFromOptions() on hold in a separate PR. -- Lisandro Dalcin ============ Research Scientist Computer, Electrical and Mathematical Sciences & Engineering (CEMSE) Extreme Computing Research Center (ECRC) King Abdullah University of Science and Technology (KAUST) http://ecrc.kaust.edu.sa/ 4700 King Abdullah University of Science and Technology al-Khawarizmi Bldg (Bldg 1), Office # 0109 Thuwal 23955-6900, Kingdom of Saudi Arabia http://www.kaust.edu.sa Office Phone: +966 12 808-0459