On 19 Sep 2019, at 11:25, Matthew Knepley via petsc-dev <petsc-dev@mcs.anl.gov<mailto:petsc-dev@mcs.anl.gov>> wrote:
I pushed the fix to the branch. Can we remerge it? I think best way would be to create another MR. You should also add #include <petscsection.h> to petscdmlabel.h. This which will also satisfy Lisandro's point. Vaclav Also, I do not understand why tests did not catch this. Its obvious what happened. I added that header to convert.c instead of convest.c. Matt On Thu, Sep 19, 2019 at 5:19 AM Stefano Zampini via petsc-dev <petsc-dev@mcs.anl.gov<mailto:petsc-dev@mcs.anl.gov>> wrote: How come this was not caught by the tests? I think we have tests with -Werror Il Gio 19 Set 2019, 12:15 Lisandro Dalcin via petsc-dev <petsc-dev@mcs.anl.gov<mailto:petsc-dev@mcs.anl.gov>> ha scritto: The warnings below are from a C build. A C++ build fails right away. We need to `#include <petscsection.h>` somewhere in the public headers, at least such that `#include <petsc.h>` in user code works. $ git grep petscsection include/ include/petsc/private/sectionimpl.h:#include <petscsection.h> include/petscis.h:#include <petscsectiontypes.h> include/petscsection.h:#include <petscsectiontypes.h> /home/devel/petsc/dev/src/snes/utils/convest.c: In function ‘PetscConvEstGetConvRate’: /home/devel/petsc/dev/src/snes/utils/convest.c:293:14: warning: implicit declaration of function ‘PetscSectionGetField’; did you mean ‘PetscSectionVecView’? [-Wimplicit-function-declaration] 293 | ierr = PetscSectionGetField(s, f, &fs);CHKERRQ(ierr); | ^~~~~~~~~~~~~~~~~~~~ | PetscSectionVecView /home/devel/petsc/dev/src/snes/utils/convest.c:294:14: warning: implicit declaration of function ‘PetscSectionGetConstrainedStorageSize’ [-Wimplicit-function-declaration] 294 | ierr = PetscSectionGetConstrainedStorageSize(fs, &lsize);CHKERRQ(ierr); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- Lisandro Dalcin ============ Research Scientist Extreme Computing Research Center (ECRC) King Abdullah University of Science and Technology (KAUST) http://ecrc.kaust.edu.sa/ -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener https://www.cse.buffalo.edu/~knepley/<http://www.cse.buffalo.edu/~knepley/>
