> On 20 Jan 2021, at 12:11 PM, Stefano Zampini <stefano.zamp...@gmail.com> > wrote: > > This is an issue with the default shell used by the makefile. Below is my > fix. We should probably have a CI machine that checks for these shell-related > errors.
I second this. Just spent too much time finding this other bash-ism in gmakefile.test… https://gitlab.com/petsc/petsc/-/commit/e4b11943e93779206a0e5f2091646de2e86b10e3#551c4017403b9179c385d5600f43348b6288a751 <https://gitlab.com/petsc/petsc/-/commit/e4b11943e93779206a0e5f2091646de2e86b10e3#551c4017403b9179c385d5600f43348b6288a751> 2021-01-20T11:21:22.5942304Z /usr/bin/sh: 1: test: false: unexpected operator 2021-01-20T11:21:22.5981176Z make: *** [gmakefile.test:270: check-test-errors] Error 1 Thanks, Pierre > diff --git a/gmakefile.test b/gmakefile.test > index c38e37f..ffd7bdb 100644 > --- a/gmakefile.test > +++ b/gmakefile.test > @@ -379,10 +379,11 @@ starttime: pre-clean $(libpetscall) > @$(eval STARTTIME := $(shell date +%s)) > > report_tests: starttime $(TESTTARGETS) > +ifeq ($(showreport),true) > @$(eval ENDTIME := $(shell date +%s)) > - -@if test ${showreport} == "true"; then elapsed_time=$$(($(ENDTIME)- > $(STARTTIME))) && \ > - $(PYTHON) $(CONFIGDIR)/report_tests.py -m $(MAKE) -d > $(TESTDIR)/counts -t 5 -e $${elapsed_time};\ > - fi > + elapsed_time=$$(($(ENDTIME)- $(STARTTIME))) && \ > + $(PYTHON) $(CONFIGDIR)/report_tests.py -m $(MAKE) -d > $(TESTDIR)/counts -t 5 -e $${elapsed_time}; > +endif > > Il giorno mar 19 gen 2021 alle ore 20:41 Scott Kruger <kru...@txcorp.com > <mailto:kru...@txcorp.com>> ha scritto: > > > I can't reproduce this with the latest master: > > hip 1261: git pull > Already up to date. > hip 1262: make -f gmakefile.test test search='notatest' > Using MAKEFLAGS: -- search=notatest > hip 1263: > > > > On 1/19/21 8:19 AM, Stefano Zampini wrote: >> Just rebased over latest master and got this >> >> zampins@vulture:~/Devel/petsc$ make -f gmakefile.test test search='notatest' >> Using MAKEFLAGS: -- search=notatest >> /bin/sh: 1: test: false: unexpected operator >> >> -- >> Stefano > > -- > Tech-X Corporation kru...@txcorp.com <mailto:kru...@txcorp.com> > 5621 Arapahoe Ave, Suite A Phone: (720) 466-3196 > Boulder, CO 80303 Fax: (303) 448-7756 > > > -- > Stefano
