Wow, how did this ever work with other compilers?

To ensure everything gets fixed, I see we have

  #define F90Array3d void

and then arguments are defined as

  F90Array3d *ptr

We could make this type-safe by

  typedef struct { void *ptr; } F90Array3d;

and use this for arguments:

  F90Array3d a



Randall Mackie <rlmackie...@gmail.com> writes:

>> On Apr 10, 2018, at 5:40 PM, Satish Balay <ba...@mcs.anl.gov> wrote:
>> 
>> On Tue, 10 Apr 2018, Jeff Hammond wrote:
>> 
>>> Can you try on a non-KNL host?  It's a bug either way but I want to
>>> determine if KNL host is the issue.
>> 
>> Breaks on 'E5-2695 v4' aswell (bebop.lcrc) with '-axcore-avx2' and 'icc 
>> (ICC) 18.0.1 20171018'
>> 
>>> Based only what I see below, Randy doesn't seem to be reporting a
>>> KNL-specific issue.  Is that incorrect?
>> 
>> Hardware details weren't mentioned in this thread.
>> 
>>> Again, there is clearly a bug here, but it helps to localize the problem as
>>> much as possible.
>> 
>>>>>>> On Thu, 5 Apr 2018, Randall Mackie wrote:
>> 
>>>>>> so I assume this is an Intel bug, but before we submit a bug
>>>>>> report I wanted to see if anyone else had similar experiences?
>> 
>> Randy,
>> 
>> I'll leave this to you to file a report with Intel.
>> 
>> Thanks,
>> Satish
>
>
> Hi Satish,
>
> As requested we filed a report with Intel, and this is their response:
>
>
>  
> From: Intel Customer Support <supportrepl...@intel.com 
> <mailto:supportrepl...@intel.com>> 
> Sent: 14 May 2018 19:56
> Subject: Intel Developer Products Support - Update to Service 
> Request#:03369230
>  
>
>  
>
> Hello,
> An update was made to service request on May 14, 2018:
>  
> Thank you for the additional information. Our engineering team investigated 
> this case. Please see the following resolution:
>
>  
>
> There is a bug in customer’s code:
>
>  
>
> At line 157 of “/src/dm/impls/da/f90-custom/zda1f90.c”
>
>  
>
> *ierr = F90Array3dDestroy(&a,PETSC_SCALAR PETSC_F90_2PTR_PARAM(ptrd));
>
>  
>
> Here “&a” should be “a” because “a” was passed from call at line 79 of 
> “test.F90” as the 3rd arguments DMDAVecRestoreArrayF90(da1,vec1,ptr_v1,ierr). 
> In fortran the array descriptor of assumed-shape array will be passed by 
> address so when it is passed to another C function it shouldn’t be taken 
> address again. There are other places in the code having the same error. 
> After removing “&” the code can be built and run without error.
>
>  
>
> In addition, this issue was discussed 4 years ago 
> https://lists.mcs.anl.gov/mailman/htdig/petsc-users/2014-April/021232.html 
> <https://lists.mcs.anl.gov/mailman/htdig/petsc-users/2014-April/021232.html> 
> without noticing the bug in the code, more likely a user coding error.
>
> I am going to close out this case as not a compiler defect. You can reopen by 
> posting a reply if you have any problem with the above resolution.
>
> Sign in 
> <https://supporttickets.intel.com/ICS_CX_Support_Request_Detail?id=5000P00000hEKLaQAO&lang=null>
>  to view and update your request or to get additional information. You can 
> also reply to this email with questions or comments.
>  
> Regards,
>  
> Devorah
> Intel Developer Products Support
>  
>
> Intel will use your personal information solely for the purpose it was 
> collected. We will not use your personal information for a different purpose 
> without first asking your permission. In order to fulfill the purpose, we may 
> need to share your personal information within Intel Corporation, Intel 
> subsidiaries worldwide, or with authorized third parties.
> Privacy <http://www.intel.com/privacy> – Cookies 
> <http://www.intel.com/cookies>
> Intel may contact you in order to obtain your feedback on the quality of the 
> support you received. We give you many choices regarding our use of your 
> personal information for quality assurance and marketing purposes. You may 
> update and request access to your contact details and communication 
> preferences by using one of the following methods: visit the specific product 
> or service website; use the Contact Us 
> <https://www-ssl.intel.com/content/www/us/en/forms/privacy-contact-us.html> 
> form; or send a letter to the postal address below.
> Intel Corporation; Mailstop RNB4-145; 2200 Mission College Blvd.; Santa 
> Clara, CA 95054 USA
> ® Intel Corporation – Legal Information 
> <http://www.intel.com/content/www/us/en/legal/terms-of-use.html> – 
> www.intel.com <http://www.intel.com/>
> Intel is a registered trademark of Intel Corporation or its subsidiaries in 
> the United States and other countries.
> *Other names and brands may be claimed as the property of others.
> *********************PLEASE DO NOT DELETE*********************
> Thread ID: ref:_00DU0YT3c._5000PhEKLa:ref
> You must include this text in any reply to this email. Thank you.
> *********************PLEASE DO NOT DELETE********************* 

Reply via email to