On Tue, 29 Oct 2019, Matthew Knepley via petsc-users wrote: > On Tue, Oct 29, 2019 at 2:35 PM Smith, Barry F. <bsm...@mcs.anl.gov> wrote: > > > > > The problem is that this change DOES use the preprocessor on the f90 > > file, does it not? We need a rule that does not use the preprocessor. > > > > This change just calls the Fortran compiler on it. The compiler decides to > use the preprocessor based on the extension (I thought).
With older releases, the primary difference between .f.o and .F.o are flag related to FPP ${PETSC_FC_INCLUDES} ${PETSCFLAGS} ${FPP_FLAGS} ${FPPFLAGS} Perhaps this difference won't matter with most compilers.. [when compiling .f sources] Satish > > Thanks, > > Matt > > > > Barry > > > > > > > On Oct 29, 2019, at 10:50 AM, Matthew Knepley via petsc-users < > > petsc-users@mcs.anl.gov> wrote: > > > > > > On Tue, Oct 29, 2019 at 11:38 AM Randall Mackie <rlmackie...@gmail.com> > > wrote: > > > Hi Matt, > > > > > > That worked and everything compiles correctly now. > > > > > > Great. > > > > > > https://gitlab.com/petsc/petsc/merge_requests/2236 > > > > > > Thanks, > > > > > > Matt > > > > > > Thanks, > > > > > > Randy > > > > > > > > >> On Oct 29, 2019, at 8:29 AM, Matthew Knepley <knep...@gmail.com> wrote: > > >> > > >> On Tue, Oct 29, 2019 at 11:25 AM Randall Mackie <rlmackie...@gmail.com> > > wrote: > > >> Correct, no preprocessing. > > >> > > >> Okay. I am not sure why it would have been remove, but you can try > > adding .f90 to lib/petsc/conf/ruls line 273 > > >> and see if that fixes it. > > >> > > >> THanks, > > >> > > >> Matt > > >>> On Oct 29, 2019, at 8:24 AM, Matthew Knepley <knep...@gmail.com> > > wrote: > > >>> > > >>> On Tue, Oct 29, 2019 at 10:54 AM Randall Mackie via petsc-users < > > petsc-users@mcs.anl.gov> wrote: > > >>> Dear PETSc users: > > >>> > > >>> In our code, we have one or two small .f90 files that are part of the > > software, and they have always compiled without any issues with previous > > versions of PETSc, using standard PETSc make files. > > >>> > > >>> However, starting with PETSc 3.12, they no longer compile. > > >>> > > >>> Was there some reasons for this change and any suggestion as to how to > > deal with this? > > >>> > > >>> My cursory look cannot find a compile rule for .f90, only .F90. Di you > > not want preprocessing on that file? > > >>> > > >>> Thanks, > > >>> > > >>> Matt > > >>> > > >>> Thanks, Randy > > >>> > > >>> > > >>> -- > > >>> What most experimenters take for granted before they begin their > > experiments is infinitely more interesting than any results to which their > > experiments lead. > > >>> -- Norbert Wiener > > >>> > > >>> https://www.cse.buffalo.edu/~knepley/ > > >> > > >> > > >> > > >> -- > > >> What most experimenters take for granted before they begin their > > experiments is infinitely more interesting than any results to which their > > experiments lead. > > >> -- Norbert Wiener > > >> > > >> https://www.cse.buffalo.edu/~knepley/ > > > > > > > > > > > > -- > > > What most experimenters take for granted before they begin their > > experiments is infinitely more interesting than any results to which their > > experiments lead. > > > -- Norbert Wiener > > > > > > https://www.cse.buffalo.edu/~knepley/ > > > > > >