Re: [pgAdmin4][Patch]: Refactor of the History Tab

[Dave Page]

Hi

On Wed, Jul 5, 2017 at 2:54 PM, Matthew Kleiman <mklei...@pivotal.io> wrote:

> 1) I see the font used for class .query-history .entry​ is monospace,
>> shouldn't it be Helvetica as per style guide ? the font for Messages > text
>> is also monospace.
>>
>
> As per Dave's comment, we have added this to the styleguide backlog.  We
> will be adding monospace entries to the styleguide.
>
> 2) Can 1px top border be added above first entry in left panel to
>> differentiate from above panels ?
>
>
> We have updated the patch to include a 1px solid #cccccc border at the
> top.
>
> 3) No query execution message appears if i run same query second time,
>> please refer screenshot.
>
>
> Appears to be fixed with Murtuza's patch.
>

I get the following error with this patch when bundling:

 [235] ./scss/pgadmin.scss 1.1 kB {3} [built] [failed] [1 error]
    + 363 hidden modules

ERROR in ./scss/pgadmin.scss
Module build failed:
@import 'primaryblue';
^
      File to import not found or unreadable: primaryblue.
Parent style sheet: stdin
      in /Users/dpage/git/pgadmin4/web/pgadmin/static/scss/pgadmin.scss
(line 4, column 1)

ERROR in ./scss/pgadmin.scss
Module build failed: ModuleBuildError: Module build failed:
@import 'primaryblue';
^
      File to import not found or unreadable: primaryblue.
Parent style sheet: stdin
      in /Users/dpage/git/pgadmin4/web/pgadmin/static/scss/pgadmin.scss
(line 4, column 1)
    at runLoaders
(/Users/dpage/git/pgadmin4/web/node_modules/webpack/lib/NormalModule.js:192:19)
    at
/Users/dpage/git/pgadmin4/web/node_modules/loader-runner/lib/LoaderRunner.js:364:11
    at
/Users/dpage/git/pgadmin4/web/node_modules/loader-runner/lib/LoaderRunner.js:230:18
    at context.callback
(/Users/dpage/git/pgadmin4/web/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at Object.asyncSassJobQueue.push [as callback]
(/Users/dpage/git/pgadmin4/web/node_modules/sass-loader/lib/loader.js:55:13)
    at Object.<anonymous>
(/Users/dpage/git/pgadmin4/web/node_modules/async/dist/async.js:2243:31)
    at Object.callback
(/Users/dpage/git/pgadmin4/web/node_modules/async/dist/async.js:906:16)
    at options.error
(/Users/dpage/git/pgadmin4/web/node_modules/node-sass/lib/index.js:294:32)
Child extract-text-webpack-plugin:
       [0]
/Users/dpage/git/pgadmin4/web/~/css-loader!/Users/dpage/git/pgadmin4/web/~/sass-loader/lib/loader.js!./scss/pgadmin.scss
247 bytes {0} [built] [failed] [1 error]

    ERROR in
/Users/dpage/git/pgadmin4/web/~/css-loader!/Users/dpage/git/pgadmin4/web/~/sass-loader/lib/loader.js!./scss/pgadmin.scss
    Module build failed:
    @import 'primaryblue';
    ^
          File to import not found or unreadable: primaryblue.
    Parent style sheet: stdin
          in /Users/dpage/git/pgadmin4/web/pgadmin/static/scss/pgadmin.scss
(line 4, column 1)



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company