On Fri, Jul 28, 2017 at 12:24 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Dave, > > On Fri, Jul 28, 2017 at 4:11 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> I took a quick look at this and have a couple of thoughts: >> >> - Instead of the "edit" icon to open the subnode, we should use something >> more appropriate - a "properties" icon perhaps. >> >> I used default subnode's edit icon for consistency purpose. > What if we go with caret-right <http://fontawesome.io/icon/caret-right/> > and caret-down <http://fontawesome.io/icon/caret-down/> icons? > That could work. > - There seems to be a lot of different shades of grey on there (maybe a >> subnode design in general that just shows up with the disabled controls), >> and the subnode control looks a bit messy as a result. >> >> Can you work with Chethana to improve the look and feel please? >> >> Do you mean only colours or subnode control design itself? > The colours, and possibly the borders etc. If Chethana comes up with an improved look and feel for subnodes in general, I'm not against changing them all. > Input from others welcome of course - screenshot attached. >> >> Thanks. >> >> On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> ++ Attaching the patch >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> PFA patch to display additional information from pg_stat_activity table >>>> using subnode control. >>>> RM#2597 >>>> >>>> Please review. >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang <sw...@pivotal.io> >>>> wrote: >>>> >>>>> >>>>>> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dp...@pgadmin.org> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <sw...@pivotal.io> >>>>>>> wrote: >>>>>>> >>>>>>>> 2-3 days is a lot of valuable engineering time. Is this a 'drop >>>>>>>> everything now' kind of feature or can this wait for some user >>>>>>>> validation >>>>>>>> on a mock up first? >>>>>>>> >>>>>>> >>>>>>> Most of the time will likely be on the infrastructure to change the >>>>>>> display to a subnode control. If you have some cycles to mockup >>>>>>> potential >>>>>>> layouts for the subnode view and have them validated, please feel free, >>>>>>> however, that seems like an awful lot of work to me to display some >>>>>>> missing >>>>>>> SQL using a standard control. >>>>>>> >>>>>> Regarding SQL display: Developing simple control to show codemirror >>>>>> in disabled state (for now) wont take that much time. >>>>>> >>>>>> >>>>> Part of a product designer's job is to make sure there is a definitive >>>>> need for a feature and that the interface for the feature is designed in >>>>> such a way that the user gets all intended value from it. Time spent >>>>> validating now will decrease the time spent later on redesigning / >>>>> reimplementing. >>>>> >>>>> If everyone is aware of what that value is and confident that how >>>>> it'll be displayed is right, there's little risk in starting to develop >>>>> it. >>>>> If we're wrong, it'll add to feature bloat and detract from the >>>>> experience. >>>>> >>>>> Would Chethana be able to take on some of the design work? It would be >>>>> valuable for the dev team to also be part of design process. >>>>> >>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company