Hi Can you rebase this please? It doesn't apply.
On Wed, Jan 31, 2018 at 6:42 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch for RM2815 > > issues fixed in updated patch > > 1. Warn user before executing query if connection was reset. > 2. Improved warning dialog. > 3. Do not show multiple dialogs while recovering from expired session or > connect reset. > 4. User should not be clicking multiple times on execute button to execute > query if > connect was lost or user session was expired. > > > [image: Inline image 1] > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Jan 15, 2018 at 11:09 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Mon, Jan 15, 2018 at 10:54 AM, Harshal Dhumal >> <harshal.dhu...@enterprisedb.com> wrote: >> > >> > Hi Dave, >> > >> > Please find rebased patch. >> > >> > Also I have made changes to existing code about showing connection >> status in query tool to make this work. >> >> >> I ran the feature tests a couple of times, and in both cases got the >> following error: >> >> ====================================================================== >> ERROR: runTest (pgadmin.feature_tests.view_da >> ta_dml_queries.CheckForViewDataTest) >> Validate Insert, Update operations in View/Edit data with given test data >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_ >> data_dml_queries.py", >> line 115, in runTest >> self._verify_row_data(True) >> File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_ >> data_dml_queries.py", >> line 289, in _verify_row_data >> self.page.find_by_id("btn-flash").click() >> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >> ges/selenium/webdriver/remote/webelement.py", >> line 80, in click >> self._execute(Command.CLICK_ELEMENT) >> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >> ges/selenium/webdriver/remote/webelement.py", >> line 501, in _execute >> return self._parent.execute(command, params) >> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >> ges/selenium/webdriver/remote/webdriver.py", >> line 308, in execute >> self.error_handler.check_response(response) >> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa >> ges/selenium/webdriver/remote/errorhandler.py", >> line 194, in check_response >> raise exception_class(message, screen, stacktrace) >> WebDriverException: Message: unknown error: Element <button >> id="btn-flash" type="button" class="btn btn-default" style="width: >> 40px;" title="Execute/Refresh (F5)">...</button> is not clickable at >> point (514, 20). Other element would receive the click: <div >> class="ajs-modal" tabindex="0">...</div> >> (Session info: chrome=63.0.3239.132) >> (Driver info: chromedriver=2.35.528157 >> (4429ca2590d6988c0745c24c8858745aaaec01ef),platform=Mac OS X 10.12.6 >> x86_64) >> >> I've attached a screenshot from the test run. >> >> Thanks, Dave >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
