Hi Joao, Yes it bundles latest version but I doubt that is not using it, If we upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. I have tried that and I started getting jQuery related errors when trying to run query tool or when running jasmine tests.
-- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > > The patches look good and they pass all tests in CI. > One think that we realized was the SlickGrid as a npm package now: > https://www.npmjs.com/package/slickgrid > Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully > supported or not...... > > Thanks > Victoria & Joao > > On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi Dave, >> >> Reverted back jQuery version to 1.x because of SlickGrid dependancy. >> Please find updated patch. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala <murtuza.zabuawala@ >> enterprisedb.com> wrote: >> >>> Please hold on my previous patch. >>> >>> We can't use latest jQuery version as SlickGrid has dependancy on older >>> version. >>> I'll send updated patch again. >>> >>> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala <murtuza.zabuawala@ >>> enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> Please find updated patches, there are two patches attached one is for >>>> the story and another is for changes required as per new modules. >>>> >>>> >>>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <dp...@pgadmin.org> wrote: >>>> >>>>> Hi >>>>> >>>>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala <murtuza.zabuawala@ >>>>> enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA patch to update the modules to latest version. >>>>>> >>>>>> >>>>> - Why isn't jQuery updated to 3.3.1? >>>>> >>>> Done >>>> >>>> >>>>> >>>>> >>>>> >>>> >>>>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2 >>>>> and pycrypto etc? >>>>> >>>> Done >>>> >>>> >>>>> >>>>> >>>>> >>>>>> We are not able to update some of the modules to latest version due >>>>>> to dependancy on other modules, For example >>>>>> - Python: Flask-Security has dependancy on flask-babelex which causes >>>>>> conflict with flask_babel >>>>>> >>>>> >>>>> Hmm, flask-babelex might be a better option anyway; in particular, it >>>>> avoids loading catalogs with every request which seems desirable given the >>>>> size of ours. On the other hand, it hasn't been updated so recently. >>>>> >>>> I have removed flask-babel and used flask_babelex instead. >>>> >>>> >>>>> >>>>> >>>>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch & >>>>>> Bootstrap Datetime picker has dependancy on Bootstrap3. >>>>>> >>>>> >>>>> OK. >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >>