On Tue, Dec 18, 2018 at 2:49 PM Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Tue, Dec 18, 2018 at 3:45 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #3780 pgAdmin4 lacks ability to specify >> NULL values in CSV export. >> >> Please review it. >> > > A few points; > > - You've included code from backports.csv, but per the licence you need to > include a description of the changes made. >
Sure. In that case I'll copy the complete file and will do my changes which is of two lines only. With my patch I have remove all the unwanted code from backport.csv. > > - Shouldn't backports.csv be removed from requirements.txt, or is it used > elsewhere? > Yes. Will do that. > > - If the previous point is true, then I'm fairly sure there is code in one > or more of the many package build scripts that adds an __init__.py file to > backports.csv in the venv that's created. > I'll remove that code as well. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*