Le jeudi 19 novembre 2009 à 08:19:06, Guillaume Lelarge a écrit :
> Le jeudi 19 novembre 2009 à 08:12:29, Dave Page a écrit :
> > On Thu, Nov 19, 2009 at 4:05 PM, Guillaume Lelarge
> >
> > <guilla...@lelarge.info> wrote:
> > > Hi,
> > >
> > > This is a bug report from Ubuntu's Launchpad. I think they are right,
> > > and wonder why we use the Alt-F4 shortcut. Probably something that was
> > > done in the first releases of pgAdmin?
> >
> > Probably - but also we've tried to standardise the keys in pgAdmin
> > across platforms, to help users that run different OSs.
> 
> AFAICT, Ctrl-Q and Ctrl-W are far more standardize on the different OSs
>  than Alt-F4. I have a bad memory, but I really don't remember using Alt-F4
>  on Mac OS X.
> 

Here is a patch that fixes this. Try it, you'll be able to use Alt-F4 or Ctrl-
Q on the main window and Alt-F4 or Ctrl-W on the other ones (querytool for 
example). Only Ctrl-Q and Ctrl-W are displayed in the Quit menu item.

Other comments?


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com
Index: pgadmin/frm/frmConfig.cpp
===================================================================
--- pgadmin/frm/frmConfig.cpp	(révision 8080)
+++ pgadmin/frm/frmConfig.cpp	(copie de travail)
@@ -128,7 +128,7 @@
     toolBar->AddSeparator();
 
     fileMenu->Append(MNU_RECENT, _("&Recent files"), recentFileMenu);
-    fileMenu->Append(MNU_EXIT, _("E&xit\tAlt-F4"), _("Exit configuration tool"));
+    fileMenu->Append(MNU_EXIT, _("E&xit\tCtrl-W"), _("Exit configuration tool"));
 
     editMenu->Append(MNU_UNDO, _("&Undo\tCtrl-Z"), _("Undo last action"), wxITEM_NORMAL);
     toolBar->AddTool(MNU_UNDO, _("Undo"), wxBitmap(edit_undo_xpm), _("Undo last action"), wxITEM_NORMAL);
Index: pgadmin/frm/frmQuery.cpp
===================================================================
--- pgadmin/frm/frmQuery.cpp	(révision 8080)
+++ pgadmin/frm/frmQuery.cpp	(copie de travail)
@@ -232,7 +232,7 @@
     fileMenu->Append(MNU_QUICKREPORT, _("&Quick report..."),  _("Run a quick report..."));
     fileMenu->AppendSeparator();
     fileMenu->Append(MNU_RECENT, _("&Recent files"), recentFileMenu);
-    fileMenu->Append(MNU_EXIT, _("E&xit\tAlt-F4"), _("Exit query window"));
+    fileMenu->Append(MNU_EXIT, _("E&xit\tCtrl-W"), _("Exit query window"));
 
     menuBar->Append(fileMenu, _("&File"));
 
Index: pgadmin/frm/frmStatus.cpp
===================================================================
--- pgadmin/frm/frmStatus.cpp	(révision 8080)
+++ pgadmin/frm/frmStatus.cpp	(copie de travail)
@@ -191,7 +191,7 @@
     menuBar = new wxMenuBar();
 
     fileMenu = new wxMenu();
-    fileMenu->Append(MNU_EXIT, _("E&xit\tAlt-F4"), _("Exit query window"));
+    fileMenu->Append(MNU_EXIT, _("E&xit\tCtrl-W"), _("Exit query window"));
 
     menuBar->Append(fileMenu, _("&File"));
 
Index: pgadmin/frm/frmMain.cpp
===================================================================
--- pgadmin/frm/frmMain.cpp	(révision 8080)
+++ pgadmin/frm/frmMain.cpp	(copie de travail)
@@ -305,7 +305,7 @@
     new pgpassConfigFileFactory(menuFactories, fileMenu, 0);
 
     fileMenu->AppendSeparator();
-    fileMenu->Append(MNU_EXIT, _("E&xit\tAlt-F4"),                _("Quit this program."));
+    fileMenu->Append(MNU_EXIT, _("E&xit\tCtrl-Q"),                _("Quit this program."));
 
     new slonyRestartFactory(menuFactories, slonyMenu, 0);
     new slonyUpgradeFactory(menuFactories, slonyMenu, 0);
-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to