On Fri, 2012-04-20 at 13:26 +0300, Heikki Linnakangas wrote: > On 20.04.2012 11:52, Guillaume Lelarge wrote: > > On Fri, 2012-04-20 at 10:47 +0200, Guillaume Lelarge wrote: > >> On Fri, 2012-04-20 at 09:21 +0100, Dave Page wrote: > >>> On Thu, Apr 19, 2012 at 9:59 PM, Heikki Linnakangas > >>> <[email protected]> wrote: > >>>> And now that I've updated my local repository, here's a third version > >>>> that > >>>> actually applies. (just my working copy didn't fix the issue) > >>> > >>> With this change, the dialogue no longer meets our design standard. > >>> > >>> Please see > >>> http://wiki.postgresql.org/wiki/PgAdmin_Internals#Property_page_dialogue_layout, > >>> which should be the standard for all new/updated dialogues, except in > >>> exceptional circumstances (with justification). > > Ah, thanks for pointing that out. > > > I took a look at the thread Heikki mentionned in his first mail. One of > > the issue he had was fixed by setting the size of the COL_NAME column. > > We don't do that if we have to show the dialog. So I added the same > > statement, and it works now. Kinda puzzling, but it works. And we still > > meet our design standard. See attached patch. > > > > Heikki, is this patch working for you? > > Yes, that fixes it. Thanks! > > While we're at it, can we make the 'value' column wider? It start really > small, and there's plenty of space in the grid. >
We now set the width of each column. The Type column and the Value column are wider. Commited and pushed. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
