On 19.01.2016 16:03, Dave Page wrote:
On Mon, Jan 18, 2016 at 1:44 AM, Andreas 'ads' Scherbaum
<[email protected]> wrote:
Hello,
we tested pgAdminIII 1.22 internally and found that it works sufficient with
Greenplum. A few minor problems are identified and we plan to work on them
as well, but nothing serious. We however know that there are a number more
serious problems with HAWQ (SQL on Hadoop), we plan to work on this as well.
As a first step, attached is a patch which removes the "unsupported version"
warning for Greenplum. The patch copies a bit infrastructure and prepares us
to support later versions of Greenplum when we bump our version number after
merging with later PostgreSQL versions. One remaining question is if the
supported versions should stay in pgConn.cpp or move to pgAdmin3.h.
Your patch won't apply again. I have no idea why - I'm trying to do it
on my Mac, which is a *nix under the hood (they don't use Mac line
endings any more - that was the old Mac OS 9 and earlier from a decade
or so ago iirc). How are you creating them? The normal way is to do
something like:
That is strange. Can someone else on the list please check if the patch
applies (and then roll it back)? I did a fresh clone (again) and it
applies clean.
Anyway - patch issues aside, isn't your patch essentially the same as
the one I was looking for feedback on just before release?
http://www.postgresql.org/message-id/flat/CACjysiUQLnddN6n=nob_0ytmnlb9sxasn1p9scwnbu3f09k...@mail.gmail.com#CACjysiUQLnddN6n=nob_0ytmnlb9sxasn1p9scwnbu3f09k...@mail.gmail.com
I clearly have missed this one. And I see that you prefer the version in
the header file.
Also I plan to add extra support for HAWQ (SQL on Hadoop, also based on
the Greenplum engine), but this has a few issues.
Ok, let me please rework this patch, and do another check for the git
config.
Regards,
--
Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
