On 15 June 2016 at 15:05, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote:
> Thanks a lot Dave. > > On 15 June 2016 at 14:09, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge >> <priyanka.shen...@enterprisedb.com> wrote: >> > Hi Dave, >> > >> > PFA updated patch. I have made changes suggested by you. >> > >> > Kindly, review and let me know for more changes. >> >> OK, I got a bit further this time, but not there yet. >> >> 1) The patch overwrote my test_config.json file. That should never >> happen (that file shouldn't be in the source tree). >> test_config.json.in should be the file that's included in the patch. >> > > OK. > >> >> 2) The updated test_config.json file is huge. > > Current configuration file web/regression/test_config.json contains test data(credentials) for each tree node; which is used while adding and updating the respective node. > I should only need to >> define one or more connections, then be able to run the tests. If you >> need to keep configuration info for "advanced users", let's put it in >> a different file to avoid confusing/scaring everyone else. Maybe split >> it into config.json for the stuff the user needs to edit >> (config.json.in would go in git), and test_config.json for the test >> configuration. > > Should i keep login and server credentials into web/regression/test_config.json file and put respective node details into config.json file of respective node's tests directory? e.g. for database node: I'll create config.json file into .../databases/tests/ directory put database add and update credentials into config.json > >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Best, > Priyanka > > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > -- Best, Priyanka EnterpriseDB Corporation The Enterprise PostgreSQL Company
