Awesome job! I've committed this with a minor tweak to the project file to complain to the user if they're not using Qt 5.5 or above. It'll still work though.
Regards, Dave. On Fri, Nov 4, 2016 at 10:35 AM, Neel Patel <neel.pa...@enterprisedb.com> wrote: > Hi, > > Please find attached initial patch for migration of runtime to QtWebEngine > from QtWebkit. > > Observation:- > > When user click on already opened link, it will not set existing tab index > but always open in new tab. > e.g. pgAdmin4 website is already open in new tab and user again open the > same website then it will not set existing tab index but always open in new > tab. > > First "createWindow" virtual protected method is getting called which does > not contain any URL of page but it will create WebEnginePage for the > WebEngineView. > Once the WebEnginePage is created in above method, we are getting > "acceptNavigationRequested" call which contains URL so before we save the > URL, tab was already opened so we are not able to compare with existing > opened tab. > > I have tested this patch on Linux & Mac and it is working as expected. > > Do review it and let us know for any comments. > > Thanks, > Neel Patel > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
