Hi On Tue, Jan 17, 2017 at 3:08 PM, Dave Page <dp...@pgadmin.org> wrote:
> Hi > > On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar > <surinder.ku...@enterprisedb.com> wrote: > > Hi > > > > Please find updated patch following changes: > > 1) Keep field 'opclass' combo box enabled. > > That doesn't seem to be working. Is the field 'opclass' is not enabled for you?. Can you please tell in which scenario it doesn't gets enabled? so that I can fix it. > > > 2) Keep ASC/DESC and NULLs FIRST/LAST options disable for access methods > > other than 'btree'. > > 3) Add validation for name field. > > Those bits do though :-) > > Please fix 1). > > Thanks! > > > On Fri, Nov 25, 2016 at 5:16 PM, Dave Page <dp...@pgadmin.org> wrote: > >> > >> On Thu, Nov 24, 2016 at 12:13 PM, Surinder Kumar > >> <surinder.ku...@enterprisedb.com> wrote: > >> > Hi > >> > > >> > Please find updated patch with change. > >> > > >> > On Fri, Oct 21, 2016 at 9:16 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> > >> >> On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar > >> >> <surinder.ku...@enterprisedb.com> wrote: > >> >> > On Fri, Oct 21, 2016 at 8:52 PM, Dave Page <dp...@pgadmin.org> > wrote: > >> >> >> > >> >> >> Hi > >> >> >> > >> >> >> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar > >> >> >> <surinder.ku...@enterprisedb.com> wrote: > >> >> >> > Hi > >> >> >> > > >> >> >> > This fix is for exclusion constraint. > >> >> >> > The options like "order" and "nulls" must be conditional. i.e. > >> >> >> > include > >> >> >> > only > >> >> >> > when access method type is other than "gist". > >> >> >> > >> >> >> When creating an index, the asc/desc options are disabled if > >> >> >> gist/gin > >> >> >> used. I think they also should be here. > >> >> >> > >> >> >> Also, what about gin indexes in this case? > >> >> > > >> >> > As per documentation, > >> >> > The access method must support amgettuple (see Chapter 52); at > >> >> > present > >> >> > this > >> >> > means GIN cannot be used > >> >> > >> >> OK, but this patch (unlike the last one) only seems to check for > gist. > >> > > >> > I have modified the code so It will check for 'gist' and 'spgist' > >> > >> Hi, > >> > >> This still doesn't seem right to me. For example, if I choose an > >> access method that doesn't have a default operator class for the > >> selected data type, Postgres asks me to explicitly choose one, which I > >> now can't because the combo box is disabled. Conversely, whilst the > >> opclass should probably not be disabled, the ASC/DESC and NULLs > >> FIRST/LAST options probably should be disabled (right now, they're > >> just ignored). > >> > >> Thoughts? > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >