Hi Dave,

Please find rebased patch.

On Wed, Apr 12, 2017 at 5:44 PM, Dave Page <dp...@pgadmin.org> wrote:

> Can you rebase this please?
>
> On Tue, Apr 11, 2017 at 1:23 PM, Surinder Kumar
> <surinder.ku...@enterprisedb.com> wrote:
> > Hi Dave,
> >
> > On Tue, Apr 11, 2017 at 4:28 PM, Dave Page <dp...@pgadmin.org> wrote:
> >>
> >> On Tue, Apr 11, 2017 at 10:51 AM, Surinder Kumar
> >> <surinder.ku...@enterprisedb.com> wrote:
> >> > Hi
> >> >
> >> > When a server is disconnected, listen to
> >> > 'pgadmin:server:disconnect'event
> >> > and trigger refresh button of Server Activity data.
> >>
> >> I don't see any reason to do that - it's not auto-refreshed data, so
> >> why clear it?
> >
> > Hmm. i agree.
> >>
> >>
> >> > Also, on server disconnect, an unused event 'server-disconnected' is
> >> > being
> >> > triggered.
> >> > instead it should trigger ''pgadmin:server:disconnect'event.
> >
> > Please find attached patch for same.
> >>
> >>
> >> Please submit that as a separate cleanup patch.
> >>
> >> Thanks.
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment: cleanup_server_js_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to