Hi Sarah
On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
> Hi Akshay!
>
>
>> Some test file names ended with "*_sql_template.py*" do we need to add
>> that string ?
>
> we added this suffix after moving the tests up a level to tables/tests to
> clarify what subject they applied to. we changed the suffix to "_sql.py"
>
> - Files "test_column_acl_sql_template.py" and "test_column_properties_sql
>> _template.py" should be moved from tables->tests to
>> tables->column->tests. As it's related to column.
>> - Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_
>> sql_template.py" should be moved from tables->tests to
>> tables->triggers->tests. As its related to triggers.
>
> these tests are related to the sql files in tables/templates/column, not
> tables/column, so moving them into tables/column would be more confusing.
>
> Following test cases are failing
>
> Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql
> doesn't fail in your environment?
>
TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with
below error:
.....\test_role_dependencies_sql.py\", line 41, in assertions\n
self.assertEqual(1, len(fetch_result))\nAssertionError: 1 != 0
> Thanks,
> George & Sarah
>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
