On Thu, Jul 13, 2017 at 9:52 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote:
> What's the operating system? > > On Jul 13, 2017 21:40, "Taylor Brown" <tay...@taytay.com> wrote: > >> pldebugger's readme said that I should file bugs here. If I'm in the >> wrong place, just let me know where to direct this report. >> >> >> This commit was checked in earlier today, and appears to have broken >> compilation for our environment: >> 7b263b911851bb129fe6f139e183f4745e574e27 >> >> Diff: >> diff --git a/pldbgapi.c b/pldbgapi.c >> index fd135a3..c536c09 100644 (file) >> --- a/pldbgapi.c >> +++ b/pldbgapi.c >> @@ -797,7 +797,7 @@ Datum pldbg_get_stack( PG_FUNCTION_ARGS ) >> */ >> snprintf( >> callCount, PLDBG_STRING_MAX_LEN, UINT64_FORMAT, >> - UINT64CONST(srf->call_cntr) >> + uint64(srf->call_cntr) >> ); >> >> values[0] = callCount; >> >> >> Link to diff: >> https://git.postgresql.org/gitweb/?p=pldebugger.git;a=blobdi >> ff;f=pldbgapi.c;h=c536c095f9203e530a8e80c3f2189aa97d96a832;h >> p=fd135a397d08425633898e5b4698781096f38775;hb=7b263b911851bb >> 129fe6f139e183f4745e574e27;hpb=24a80d6a475e6e60f37787da5f1e4a4b7e600b59 >> >> Sent a patch to resolve the issue to Dave. It was my mistake. Thanks for reporting. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> > Here's the error after cloning the repo and running make: >> >> jenkins-node-29% USE_PGXS=1 make >> gcc -Wall -Wmissing-prototypes -Wpointer-arith >> -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute >> -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard >> -g -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat >> -Werror=format-security -I/usr/include/mit-krb5 -fPIC -pie >> -fno-omit-frame-pointer -fpic -I. -I./ -I/usr/include/postgresql/9.6/server >> -I/usr/include/postgresql/internal -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE >> -I/usr/include/libxml2 -I/usr/include/tcl8.6 -c -o pldbgapi.o pldbgapi.c >> pldbgapi.c: In function ‘pldbg_get_stack’: >> pldbgapi.c:800:4: error: expected expression before ‘uint64’ >> uint64(srf->call_cntr) >> ^ >> make: *** [pldbgapi.o] Error 1 >> >> >> Here's our gcc version: >> gcc --version >> gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 >> >> >> My C is rusty, so I am afraid I don't have a great suggestion other than >> reverting the change :) Please let me know if I can do anything to help. >> >> >>
