> yep, exactly. The code for that is already in the repository. But there are a
> few considerations to be made such as launching and waiting for the python
> server to be up when the window is opened, ensuring the port number is fixed
> or matches the one used by the server and some sort of secret key exchange
> and context menus.
Is there a ticket or a branch that I can follow for the electron code?
On Friday, August 9, 2019, 3:00:37 PM GMT+8, Avin Kavish <avinkav...@gmail.com>
wrote:
okay, my point is that an answer was given to Luther which I believe helped him
solve his problem :) Just trying to save you the energy of looking into this in
detail, that is all :) Sometimes I shorten what I'm thinking to a few words and
it leaves it open to interpretation.
On Fri, Aug 9, 2019 at 11:50 AM Dave Page <dp...@pgadmin.org> wrote:
> Right - I’m just point out that you may be able to add a command line option
> to tell your browser to use a new window.
>
> -- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB
> UK:http://www.enterprisedb.comThe Enterprise PostgreSQL Company
>
> On 9 Aug 2019, at 06:52, Avin Kavish <avinkav...@gmail.com> wrote:
>
>> @Luther Goh Lu Feng Electron launch option is going to be optional as far
>> as I'm aware
>>
>> @Dave Page I think Khushboo linked a screenshot with the settings
>>
>> On Fri, Aug 9, 2019 at 11:14 AM Dave Page <dp...@pgadmin.org> wrote:
>>> I’m on my phone so can’t provide details, but some browsers offer command
>>> line options you can use in the config dialog to use a new window. In some,
>>> you may need to settle for an alternate profile.
>>>
>>> -- Dave PageBlog: http://pgsnake.blogspot.comTwitter: @pgsnakeEnterpriseDB
>>> UK:http://www.enterprisedb.comThe Enterprise PostgreSQL Company
>>>
>>> On 9 Aug 2019, at 06:00, Luther Goh Lu Feng <elf...@yahoo.com> wrote:
>>>
>>>> I see. I actually appreciate that pgAdmin is in a web browser, just that
>>>> it was frustrating that it opens in a new tab instead of a window. But I
>>>> guess it is impossible to make all users happy so I will rest my case for
>>>> now.
>>>>
>>>> In any case, a brief look at the code[1] seems to suggest that it may not
>>>> be trivial to implement my request.
>>>>
>>>> Thanks for the feedback anyway! 🙇🏻♂️
>>>>
>>>> --Luther
>>>>
>>>>
>>>>
>>>> On Friday, August 9, 2019, 12:55:08 PM GMT+8, Avin Kavish
>>>> <avinkav...@gmail.com> wrote:
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> yep, exactly. The code for that is already in the repository. But there
>>>> are a few considerations to be made such as launching and waiting for the
>>>> python server to be up when the window is opened, ensuring the port number
>>>> is fixed or matches the one used by the server and some sort of secret key
>>>> exchange and context menus.
>>>>
>>>> On Fri, Aug 9, 2019 at 10:13 AM Michel Feinstein
>>>> <michelfeinst...@gmail.com> wrote:
>>>>> I think this would be a lot easier, as you are just basically wrapping a
>>>>> browser with a fixed URL address.
>>>>>
>>>>> On Fri, Aug 9, 2019, 01:39 Avin Kavish <avinkav...@gmail.com> wrote:
>>>>>> The people who want it don't want a browser window, they want an
>>>>>> independent standalone application that is not affected by what they
>>>>>> might do with the browser.
>>>>>>
>>>>>> On Fri, Aug 9, 2019 at 10:08 AM Luther Goh Lu Feng <elf...@yahoo.com>
>>>>>> wrote:
>>>>>>> Thanks for sharing the plans for electron.
>>>>>>>
>>>>>>> In my feature suggestion for a new window, I am not referring to a new
>>>>>>> window using electron, but instead I meant a new window in the existing
>>>>>>> web browser.
>>>>>>>
>>>>>>> I am unfamiliar with the effort needed for electron integration. But I
>>>>>>> suspect that opening a new window in an existing web browser should be
>>>>>>> much more easily achievable.
>>>>>>>
>>>>>>> Wdyt?
>>>>>>>
>>>>>>> --Luther
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Friday, August 9, 2019, 12:31:56 PM GMT+8, Ashesh Vashi
>>>>>>> <ashesh.va...@enterprisedb.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Aug 9, 2019 at 9:57 AM Luther Goh Lu Feng <elf...@yahoo.com>
>>>>>>> wrote:
>>>>>>>> Thanks for the suggestion!. That is very useful, and would work for me
>>>>>>>> as a personal custom configuration.
>>>>>>>>
>>>>>>>> However, I have read some complaints in the mailing list about how
>>>>>>>> pgAdmin 4 opens a web page in a new tab, unlike pgAdmin3. I do wonder
>>>>>>>> if changing the default behaviour to open in a new window would
>>>>>>>> possibly address those complaints, make it more similar to pgAdmin 3
>>>>>>> We would love to have a separate window for pgAdmin 4, hence - we're
>>>>>>> already working on the POC (using electron), and it is a side line
>>>>>>> project, and getting delayed due to limited resources working on the
>>>>>>> pgAdmin 4.
>>>>>>>
>>>>>>> I would like to invite other python/electron developers to help us
>>>>>>> evolving the project in correct direction.
>>>>>>>
>>>>>>> -- Thanks, Ashesh
>>>>>>>>
>>>>>>>>
>>>>>>>> As an aside, is there a generic command that does the default browser
>>>>>>>> in a new window? I am using firefox now and have switched to and fro
>>>>>>>> from Chrome. It would be convenient if there is a single command that
>>>>>>>> applies for both browsers!
>>>>>>>>
>>>>>>>> --Luther
>>>>>>>>
>>>>>>>>
>>>>>>>> On Friday, August 9, 2019, 12:17:57 PM GMT+8, Khushboo Vashi
>>>>>>>> <khushboo.va...@enterprisedb.com> wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> On Thu, Aug 8, 2019 at 11:18 PM Luther Goh Lu Feng <elf...@yahoo.com>
>>>>>>>> wrote:
>>>>>>>>> The current default behaviour of pgAdmin4 is to load a webpage in a
>>>>>>>>> new default browser tab, on the extreme right of all tabs. I find
>>>>>>>>> that less than ideal in the scenario where I have a large number of
>>>>>>>>> tabs in firefox, eg, 50, and I will be abruptly brought to that tab
>>>>>>>>> when pgAdmin 4 loads
>>>>>>>>>
>>>>>>>>> I would like to suggest an alternative user flow, where the pgAdmin
>>>>>>>>> loads in a new window. This could be an option, that could be toggled
>>>>>>>>> on and off with a checkbox. I would even go as far to suspect that
>>>>>>>>> this may be more welcomed as the default behaviour
>>>>>>>>>
>>>>>>>> pgAdmin configuration window provides the way to set the browser
>>>>>>>> options. You can set the appropriate command for your browser to
>>>>>>>> always open pgAdmin in the new window.
>>>>>>>>
>>>>>>>> Right click on the pgAdmin 4 taskbar icon (elephant icon) > Select
>>>>>>>> Configure > Set the command for the "Browser Command" option.
>>>>>>>>
>>>>>>>> I have attached the Chrome configuration for the new window for your
>>>>>>>> reference.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Khushboo
>>>>>>>>>
>>>>>>>>> Wdyt?
>>>>>>>>>
>>>>>>>>> --Luther
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>
