I built pgpool-II 2.3.2.2 and found several compiler warnings. Almost of them seem to be harmless, but might be a problem on minor platforms. The attached patch is to quiet compilers.
However, warnings about unhandled ACL_OBJECT_COLUMN, ACL_OBJECT_FDW and ACL_OBJECT_FOREIGN_SERVER might be user-visible issues. Can pgpool send DDLs using such kinds of objects properly? (I didn't test them, sorry) Routines for FDW and FOREIGN_SERVER are included in the attached patch, but COLUMN is still warned. They would need to be handled by special syntax.
$ gcc --version gcc (GCC) 4.4.0 20090506 (Red Hat 4.4.0-4) Copyright (C) 2009 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ make | grep 警告 gram.y: In function ‘base_yyparse’: gram.y:8762: 警告: statement with no effect gram.y: In function ‘insertSelectOptions’: gram.y:10898: 警告: statement with no effect gram.y: トップレベル: scan.c:2224: 警告: ‘input’ defined but not used makefuncs.c: In function ‘flatCopyTargetEntry’: makefuncs.c:142: 警告: statement with no effect outfuncs.c: In function ‘_outGrantStmt’: outfuncs.c:3493: 警告: enumeration value ‘ACL_OBJECT_COLUMN’ not handled in switch outfuncs.c:3493: 警告: enumeration value ‘ACL_OBJECT_FDW’ not handled in switch outfuncs.c:3493: 警告: enumeration value ‘ACL_OBJECT_FOREIGN_SERVER’ not handled in switch copyfuncs.c: In function ‘_copyList’: copyfuncs.c:2496: 警告: value computed is not used pcp.c: In function 'pcp_disconnect': pcp.c:296: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int' pcp.c: In function 'pcp_connect': pcp.c:130: warning: dereferencing pointer 'addr.26' does break strict-aliasing rules pcp.c:130: note: initialized from here main.c: In function ‘create_unix_domain_socket’: main.c:1037: 警告: dereferencing pointer ‘addr.116’ does break strict-aliasing rules main.c:1037: note: initialized from here main.c: In function ‘create_inet_domain_socket’: main.c:973: 警告: dereferencing pointer ‘addr.107’ does break strict-aliasing rules main.c:973: note: initialized from here pool_config.c:1198: 警告: ‘input’ defined but not used pool_connection_pool.c: In function ‘connect_inet_domain_socket_by_port’: pool_connection_pool.c:499: 警告: dereferencing pointer ‘addr.146’ does break strict-aliasing rules pool_connection_pool.c:499: note: initialized from here pool_connection_pool.c: In function ‘connect_unix_domain_socket_by_port’: pool_connection_pool.c:452: 警告: dereferencing pointer ‘addr.142’ does break strict-aliasing rules pool_connection_pool.c:452: note: initialized from here pool_ip.c: In function ‘SockAddr_cidr_mask’: pool_ip.c:455: 警告: ‘mask4.sin_zero[7u]’ may be used uninitialized in this function pool_ip.c:455: 警告: ‘mask4.sin_zero[6u]’ may be used uninitialized in this function pool_ip.c:455: 警告: ‘mask4.sin_zero[5u]’ may be used uninitialized in this function pool_ip.c:455: 警告: ‘mask4.sin_zero[4u]’ may be used uninitialized in this function pool_ip.c:455: 警告: ‘mask4.sin_zero[3u]’ may be used uninitialized in this function pool_ip.c:455: 警告: ‘mask4.sin_zero[2u]’ may be used uninitialized in this function pool_ip.c:455: 警告: ‘mask4.sin_zero[1u]’ may be used uninitialized in this function pool_ip.c:455: 警告: ‘mask4.sin_zero[0u]’ may be used uninitialized in this function pool_lobj.c: In function ‘pool_rewrite_lo_creat’: pool_lobj.c:106: 警告: キャストによってポインタから異なるサイズの整数となります pool_lobj.c:135: 警告: キャストによってポインタから異なるサイズの整数となります
suppress_warning.diff
Description: Binary data
_______________________________________________ Pgpool-hackers mailing list [email protected] http://pgfoundry.org/mailman/listinfo/pgpool-hackers
