On Mon, Jan 30, 2006 at 08:21:34AM -0500, Andrew Dunstan wrote: > > > David Fetter wrote: > > > > >+ /* Disallow BADCHARS characters */ > >+ if (strcspn(cstate->delim, BADCHARS) != 1) > >+ ereport(ERROR, > >+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), > >+ errmsg("COPY delimiter cannot be \"%#02x\"", > >+ *cstate->delim))); > >+ > > Is ERRCODE_FEATURE_NOT_SUPPORTED the right errcode? This isn't a > missing feature; we are performing a sanity check here. We can > reasonably expect never to support CR, LF or \ as the text > delimiter.
I guess that depends on whether we ever plan to allow people to set the output record separator to something other than CR?LF. > Maybe ERRCODE_INVALID_PARAMETER_VALUE ? Or maybe we need a new one. > > Also, I would probably make the format %#.02x so the result would > look like 0x0d (for a CR). > > (I bet David never thought there would so much fuss over a handful > of lines of code) Actually, I'm happy to see it's getting QA. COPY is something that has Consequences⢠if anything goes wrong with it, so I'd rather do best efforts up front to get it right. :) Cheers, D -- David Fetter [EMAIL PROTECTED] http://fetter.org/ phone: +1 415 235 3778 Remember to vote! ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match