Magnus Hagander wrote: > Andrew Dunstan wrote: >> >> Tom Lane wrote: >>> Bruce Momjian <[EMAIL PROTECTED]> writes: >>> >>>> Tom Lane wrote: >>>> >>>>> Well, why is that a bug? If the platform is so silly as to define text >>>>> files that way, who are we to argue? >>>>> >>> >>>> The problem is that our pg_controldata might have binary values that >>>> contain 0x1a that will be confused by the operating system as >>>> end-of-file. >>>> >>> pg_controldata is certainly already being read as binary. >> Umm, no, it is in the backend I believe but not in the utilities. Hence >> the original bug report. We need to add the binary flag in >> pg_controldata.c and pg_resetxlog.c. > > Right. > I'll go ahead and put that part in (I find two locations - the one in > the original patch, and the extra one Heikki noticed).
Eh, both were in the original patch, I just didn't scroll far enough :-) Applied to HEAD and backpatched back to 8.2 - since it only affects Windows, we don't go further. //Magnus -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
